base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

chrome/browser/extensions/permission_messages_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/macros.h"
@@ skipping 248 matching lines @@
   std::unique_ptr<ChromePermissionMessageProvider> message_provider_;
 };
 
 TEST_F(USBDevicePermissionMessagesTest, SingleDevice) {
   {
     const char kMessage[] =
         "Access any PVR Mass Storage from HUMAX Co., Ltd. via USB";
 
     std::unique_ptr<base::ListValue> permission_list(new base::ListValue());
     permission_list->Append(
-        UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue().release());
+        UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue());
 
     UsbDevicePermission permission(
         PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));
     ASSERT_TRUE(permission.FromValue(permission_list.get(), NULL, NULL));
 
     PermissionMessages messages = GetMessages(permission.GetPermissions());
     ASSERT_EQ(1U, messages.size());
     EXPECT_EQ(base::ASCIIToUTF16(kMessage), messages.front().message());
   }
   {
     const char kMessage[] = "Access USB devices from HUMAX Co., Ltd.";
 
     std::unique_ptr<base::ListValue> permission_list(new base::ListValue());
     permission_list->Append(
-        UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue().release());
+        UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue());
 
     UsbDevicePermission permission(
         PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));
     ASSERT_TRUE(permission.FromValue(permission_list.get(), NULL, NULL));
 
     PermissionMessages messages = GetMessages(permission.GetPermissions());
     ASSERT_EQ(1U, messages.size());
     EXPECT_EQ(base::ASCIIToUTF16(kMessage), messages.front().message());
   }
   {
     const char kMessage[] = "Access USB devices from an unknown vendor";
 
     std::unique_ptr<base::ListValue> permission_list(new base::ListValue());
     permission_list->Append(
-        UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue().release());
+        UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue());
 
     UsbDevicePermission permission(
         PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));
     ASSERT_TRUE(permission.FromValue(permission_list.get(), NULL, NULL));
 
     PermissionMessages messages = GetMessages(permission.GetPermissions());
     ASSERT_EQ(1U, messages.size());
     EXPECT_EQ(base::ASCIIToUTF16(kMessage), messages.front().message());
   }
 }
 
 TEST_F(USBDevicePermissionMessagesTest, MultipleDevice) {
   const char kMessage[] = "Access any of these USB devices";
   const char* kDetails[] = {
       "PVR Mass Storage from HUMAX Co., Ltd.",
       "unknown devices from HUMAX Co., Ltd.",
       "devices from an unknown vendor"
   };
 
   // Prepare data set
   std::unique_ptr<base::ListValue> permission_list(new base::ListValue());
   permission_list->Append(
-      UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue().release());
+      UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue());
   // This device's product ID is not in Chrome's database.
   permission_list->Append(
-      UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue().release());
+      UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue());
   // This additional unknown product will be collapsed into the entry above.
   permission_list->Append(
-      UsbDevicePermissionData(0x02ad, 0x138e, -1).ToValue().release());
+      UsbDevicePermissionData(0x02ad, 0x138e, -1).ToValue());
   // This device's vendor ID is not in Chrome's database.
   permission_list->Append(
-      UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue().release());
+      UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue());
   // This additional unknown vendor will be collapsed into the entry above.
   permission_list->Append(
-      UsbDevicePermissionData(0x02af, 0x138d, -1).ToValue().release());
+      UsbDevicePermissionData(0x02af, 0x138d, -1).ToValue());
 
   UsbDevicePermission permission(
       PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));
   ASSERT_TRUE(permission.FromValue(permission_list.get(), NULL, NULL));
 
   PermissionMessages messages = GetMessages(permission.GetPermissions());
   ASSERT_EQ(1U, messages.size());
   EXPECT_EQ(base::ASCIIToUTF16(kMessage), messages.front().message());
   const std::vector<base::string16>& submessages =
       messages.front().submessages();
   ASSERT_EQ(arraysize(kDetails), submessages.size());
   for (size_t i = 0; i < submessages.size(); i++)
     EXPECT_EQ(base::ASCIIToUTF16(kDetails[i]), submessages[i]);
 }
 
 }  // namespace extensions