components/invalidation/impl/unacked_invalidation_set.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/unacked_invalidation_set.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/invalidation/impl/invalidator_storage.cc ('k') | components/invalidation/impl/unacked_invalidation_set_test_util.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/impl/unacked_invalidation_set.cc

diff --git a/components/invalidation/impl/unacked_invalidation_set.cc b/components/invalidation/impl/unacked_invalidation_set.cc

index 78bcfa3314c81967ce3039bf67033689b793b86b..ece3176926e5d2e3b4298e4b6fac515e74f09a63 100644

--- a/components/invalidation/impl/unacked_invalidation_set.cc

+++ b/components/invalidation/impl/unacked_invalidation_set.cc

@@ -165,7 +165,7 @@ std::unique_ptr<base::DictionaryValue> UnackedInvalidationSet::ToValue() const {

std::unique_ptr<base::ListValue> list_value(new base::ListValue);

for (InvalidationsSet::const_iterator it = invalidations_.begin();

it != invalidations_.end(); ++it) {

- list_value->Append(it->ToValue().release());

+ list_value->Append(it->ToValue());

}

value->Set(kInvalidationListKey, list_value.release());