chrome/browser/extensions/permission_messages_unittest.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Unified Diff: chrome/browser/extensions/permission_messages_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/menu_manager.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/permission_messages_unittest.cc

diff --git a/chrome/browser/extensions/permission_messages_unittest.cc b/chrome/browser/extensions/permission_messages_unittest.cc

index 68a212c7bf004ba6de51c9ebad7490bcf10cdd33..d0cdccb994aa4708f15aeb7da1a60351d078329b 100644

--- a/chrome/browser/extensions/permission_messages_unittest.cc

+++ b/chrome/browser/extensions/permission_messages_unittest.cc

@@ -266,7 +266,7 @@ TEST_F(USBDevicePermissionMessagesTest, SingleDevice) {

std::unique_ptr<base::ListValue> permission_list(new base::ListValue());

permission_list->Append(

- UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue().release());

+ UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue());

UsbDevicePermission permission(

PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));

@@ -281,7 +281,7 @@ TEST_F(USBDevicePermissionMessagesTest, SingleDevice) {

std::unique_ptr<base::ListValue> permission_list(new base::ListValue());

permission_list->Append(

- UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue().release());

+ UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue());

UsbDevicePermission permission(

PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));

@@ -296,7 +296,7 @@ TEST_F(USBDevicePermissionMessagesTest, SingleDevice) {

std::unique_ptr<base::ListValue> permission_list(new base::ListValue());

permission_list->Append(

- UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue().release());

+ UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue());

UsbDevicePermission permission(

PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));

@@ -319,19 +319,19 @@ TEST_F(USBDevicePermissionMessagesTest, MultipleDevice) {

// Prepare data set

std::unique_ptr<base::ListValue> permission_list(new base::ListValue());

permission_list->Append(

- UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue().release());

+ UsbDevicePermissionData(0x02ad, 0x138c, -1).ToValue());

// This device's product ID is not in Chrome's database.

permission_list->Append(

- UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue().release());

+ UsbDevicePermissionData(0x02ad, 0x138d, -1).ToValue());

// This additional unknown product will be collapsed into the entry above.

permission_list->Append(

- UsbDevicePermissionData(0x02ad, 0x138e, -1).ToValue().release());

+ UsbDevicePermissionData(0x02ad, 0x138e, -1).ToValue());

// This device's vendor ID is not in Chrome's database.

permission_list->Append(

- UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue().release());

+ UsbDevicePermissionData(0x02ae, 0x138d, -1).ToValue());

// This additional unknown vendor will be collapsed into the entry above.

permission_list->Append(

- UsbDevicePermissionData(0x02af, 0x138d, -1).ToValue().release());

+ UsbDevicePermissionData(0x02af, 0x138d, -1).ToValue());

UsbDevicePermission permission(

PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));