Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6646)

Unified Diff: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
index 8ef6ebd7cfddd1eb7a7974fbd1a6af403bf04295..3125778aa68afb6e2afb2f67c2a4c31559d4aa9f 100644
--- a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/webui/settings/settings_startup_pages_handler.h"
#include <string>
+#include <utility>
#include <vector>
#include "chrome/browser/prefs/session_startup_pref.h"
@@ -80,7 +81,7 @@ void StartupPagesHandler::OnModelChanged() {
entry->SetString("tooltip",
startup_custom_pages_table_model_.GetTooltip(i));
entry->SetInteger("modelIndex", i);
- startup_pages.Append(entry.release());
+ startup_pages.Append(std::move(entry));
}
CallJavascriptFunction("cr.webUIListenerCallback",

Powered by Google App Engine
This is Rietveld 408576698