Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
asanka, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, markusheintz_, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-options_chromium.org, mlamouri+watch-notifications_chromium.org, msramek+watch_chromium.org, nona+watch_chromium.org, pam+watch_chromium.org, Peter Beverloo, raymes+watch_chromium.org, rginda+watch_chromium.org, samuong+watch_chromium.org, shuchen+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, sync-reviews_chromium.org, tfarina, Lei Zhang, tommycli, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715 Cr-Commit-Position: refs/heads/master@{#397580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -321 lines) Patch
M chrome/browser/background/background_application_list_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 7 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/tabs/windows_event_router.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/policy_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/policy_handlers_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_test_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/net/predictor.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notifier_state_tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 18 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tracing/chrome_tracing_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/invalidations_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_import_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/font_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/common_extension_api_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 9 chunks +24 lines, -24 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:17:10 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-02 23:39:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030013003/1
4 years, 6 months ago (2016-06-03 00:57:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 02:27:31 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:30:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9ea6386f5238349f13baa3e3f48d7c6f115e715
Cr-Commit-Position: refs/heads/master@{#397580}

Powered by Google App Engine
This is Rietveld 408576698