chrome/browser/download/download_query_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_query_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_policy_provider_unittest.cc ('k') | chrome/browser/extensions/api/autotest_private/autotest_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_query_unittest.cc

diff --git a/chrome/browser/download/download_query_unittest.cc b/chrome/browser/download/download_query_unittest.cc

index e8fcad562fe54c89fcc3e2308a7e72ec32ce8ca6..d34a4b9eb96d9636f094fc0b2e10d74806091836 100644

--- a/chrome/browser/download/download_query_unittest.cc

+++ b/chrome/browser/download/download_query_unittest.cc

@@ -135,7 +135,7 @@ template<> void DownloadQueryTest::AddFilter(

std::unique_ptr<base::ListValue> list(new base::ListValue());

for (std::vector<base::string16>::const_iterator it = cpp_value.begin();

it != cpp_value.end(); ++it) {

- list->Append(new base::StringValue(*it));

+ list->AppendString(*it);

}

CHECK(query_.AddFilter(name, *list.get()));

}

@@ -145,7 +145,7 @@ template<> void DownloadQueryTest::AddFilter(

std::unique_ptr<base::ListValue> list(new base::ListValue());

for (std::vector<std::string>::const_iterator it = cpp_value.begin();

it != cpp_value.end(); ++it) {

- list->Append(new base::StringValue(*it));

+ list->AppendString(*it);

}

CHECK(query_.AddFilter(name, *list.get()));

}