Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/signin/fake_signin_manager_builder.h"
 #include "chrome/browser/signin/signin_error_controller_factory.h"
@@ skipping 157 matching lines @@
   // Stop Sync before signing out.
   SupervisedUserSyncService* sync_service_ =
       SupervisedUserSyncServiceFactory::GetForProfile(profile());
   sync_service_->StopSyncing(syncer::SUPERVISED_USERS);
 
   // Sign out the user.
   signin_manager()->ForceSignOut();
 
   // Test the JS -> C++ -> JS callback path.
   base::ListValue list_args;
-  list_args.Append(new base::StringValue(kTestCallbackId));
-  list_args.Append(new base::StringValue(profile()->GetPath().AsUTF16Unsafe()));
+  list_args.AppendString(kTestCallbackId);
+  list_args.AppendString(profile()->GetPath().AsUTF16Unsafe());
   handler()->GetExistingSupervisedUsers(&list_args);
 
   // Expect an error response.
   VerifyResponse(1U, kTestCallbackId, false);
 
   base::string16 expected_error_message = l10n_util::GetStringUTF16(
       IDS_PROFILES_CREATE_CUSTODIAN_ACCOUNT_DETAILS_OUT_OF_DATE_ERROR);
   base::string16 error_message;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg3()->GetAsString(&error_message));
   EXPECT_EQ(expected_error_message, error_message);
 }
 
 TEST_F(SigninSupervisedUserImportHandlerTest, AuthError) {
   // Set Auth Error.
   const GoogleServiceAuthError error(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
   FakeAuthStatusProvider provider(
       SigninErrorControllerFactory::GetForProfile(profile()));
   provider.SetAuthError(kTestGaiaId, error);
 
   // Test the JS -> C++ -> JS callback path.
   base::ListValue list_args;
-  list_args.Append(new base::StringValue(kTestCallbackId));
-  list_args.Append(new base::StringValue(profile()->GetPath().AsUTF16Unsafe()));
+  list_args.AppendString(kTestCallbackId);
+  list_args.AppendString(profile()->GetPath().AsUTF16Unsafe());
   handler()->GetExistingSupervisedUsers(&list_args);
 
   // Expect an error response.
   VerifyResponse(1U, kTestCallbackId, false);
 
   base::string16 expected_error_message = l10n_util::GetStringUTF16(
       IDS_PROFILES_CREATE_CUSTODIAN_ACCOUNT_DETAILS_OUT_OF_DATE_ERROR);
   base::string16 error_message;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg3()->GetAsString(&error_message));
   EXPECT_EQ(expected_error_message, error_message);
 }
 
 TEST_F(SigninSupervisedUserImportHandlerTest, CustodianIsSupervised) {
   // Build a supervised test profile.
   TestingProfile* profile_ = profile_manager()->CreateTestingProfile(
       "supervised-test-profile",
       std::unique_ptr<syncable_prefs::PrefServiceSyncable>(),
       base::UTF8ToUTF16("supervised-test-profile"),
       0,
       "12345",  // supervised_user_id
       TestingProfile::TestingFactories());
 
   // Test the JS -> C++ -> JS callback path.
   base::ListValue list_args;
-  list_args.Append(new base::StringValue(kTestCallbackId));
-  list_args.Append(new base::StringValue(profile_->GetPath().AsUTF16Unsafe()));
+  list_args.AppendString(kTestCallbackId);
+  list_args.AppendString(profile_->GetPath().AsUTF16Unsafe());
   handler()->GetExistingSupervisedUsers(&list_args);
 
   // Expect to do nothing.
   EXPECT_EQ(0U, web_ui()->call_data().size());
 }
 
 TEST_F(SigninSupervisedUserImportHandlerTest, SendExistingSupervisedUsers) {
   // Test the JS -> C++ -> JS callback path.
   base::ListValue list_args;
-  list_args.Append(new base::StringValue(kTestCallbackId));
-  list_args.Append(new base::StringValue(profile()->GetPath().AsUTF16Unsafe()));
+  list_args.AppendString(kTestCallbackId);
+  list_args.AppendString(profile()->GetPath().AsUTF16Unsafe());
   handler()->GetExistingSupervisedUsers(&list_args);
 
   // Expect a success response.
   VerifyResponse(1U, kTestCallbackId, true);
 
   const base::ListValue* supervised_users;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg3()->GetAsList(&supervised_users));
   EXPECT_EQ(1U, supervised_users->GetSize());
 
   const base::DictionaryValue* supervised_user;
   ASSERT_TRUE(supervised_users->GetDictionary(0, &supervised_user));
   std::string id;
   ASSERT_TRUE(supervised_user->GetString("id", &id));
   EXPECT_EQ(kSupervisedUserId, id);
   std::string name;
   ASSERT_TRUE(supervised_user->GetString("name", &name));
   EXPECT_EQ(kSupervisedUsername, name);
   std::string iconURL;
   ASSERT_TRUE(supervised_user->GetString("iconURL", &iconURL));
   EXPECT_EQ(kSupervisedUserAvatarUrl, iconURL);
   bool onCurrentDevice;
   ASSERT_TRUE(supervised_user->GetBoolean("onCurrentDevice", &onCurrentDevice));
   ASSERT_FALSE(onCurrentDevice);
 }