Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
index 06b23ea92f48b5812bae9b85316a8cb762a01ce0..8efcae0e313a75efdda78bc0f163ff391ab6dd2c 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
@@ -497,7 +497,7 @@ bool GenerateInfoSpec(const std::string& values, int* result) {
for (const std::string& cur :
base::SplitString(values, ",", base::KEEP_WHITESPACE,
base::SPLIT_WANT_NONEMPTY))
- list_value.Append(new base::StringValue(cur));
+ list_value.AppendString(cur);
return ExtraInfoSpec::InitFromValue(list_value, result);
}
@@ -1262,11 +1262,11 @@ TEST(ExtensionWebRequestHelpersTest,
TEST(ExtensionWebRequestHelpersTest, TestStringToCharList) {
base::ListValue list_value;
- list_value.Append(new base::FundamentalValue('1'));
- list_value.Append(new base::FundamentalValue('2'));
- list_value.Append(new base::FundamentalValue('3'));
- list_value.Append(new base::FundamentalValue(0xFE));
- list_value.Append(new base::FundamentalValue(0xD1));
+ list_value.AppendInteger('1');
+ list_value.AppendInteger('2');
+ list_value.AppendInteger('3');
+ list_value.AppendInteger(0xFE);
+ list_value.AppendInteger(0xD1);
unsigned char char_value[] = {'1', '2', '3', 0xFE, 0xD1};
std::string string_value(reinterpret_cast<char *>(char_value), 5);

Powered by Google App Engine
This is Rietveld 408576698