Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/permissions/permissions_api_helpers.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 67 matching lines @@
       UnpackPermissionSet(permissions_object, true, &error);
   EXPECT_TRUE(error.empty());
 
   EXPECT_EQ(permission_set, *from_value);
 }
 
 // Tests various error conditions and edge cases when unpacking values
 // into PermissionSets.
 TEST(ExtensionPermissionsAPIHelpers, Unpack) {
   std::unique_ptr<base::ListValue> apis(new base::ListValue());
-  apis->Append(new base::StringValue("tabs"));
+  apis->AppendString("tabs");
   std::unique_ptr<base::ListValue> origins(new base::ListValue());
-  origins->Append(new base::StringValue("http://a.com/*"));
+  origins->AppendString("http://a.com/*");
 
   std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
   std::unique_ptr<const PermissionSet> permissions;
   std::string error;
 
   // Origins shouldn't have to be present.
   {
     Permissions permissions_object;
     value->Set("permissions", apis->DeepCopy());
     EXPECT_TRUE(Permissions::Populate(*value, &permissions_object));
@@ skipping 13 matching lines @@
     EXPECT_TRUE(permissions.get());
     EXPECT_TRUE(error.empty());
     EXPECT_TRUE(permissions->HasExplicitAccessToOrigin(GURL("http://a.com/")));
   }
 
   // Throw errors for non-string API permissions.
   {
     Permissions permissions_object;
     value->Clear();
     std::unique_ptr<base::ListValue> invalid_apis(apis->DeepCopy());
-    invalid_apis->Append(new base::FundamentalValue(3));
+    invalid_apis->AppendInteger(3);
     value->Set("permissions", invalid_apis->DeepCopy());
     EXPECT_FALSE(Permissions::Populate(*value, &permissions_object));
   }
 
   // Throw errors for non-string origins.
   {
     Permissions permissions_object;
     value->Clear();
     std::unique_ptr<base::ListValue> invalid_origins(origins->DeepCopy());
-    invalid_origins->Append(new base::FundamentalValue(3));
+    invalid_origins->AppendInteger(3);
     value->Set("origins", invalid_origins->DeepCopy());
     EXPECT_FALSE(Permissions::Populate(*value, &permissions_object));
   }
 
   // Throw errors when "origins" or "permissions" are not list values.
   {
     Permissions permissions_object;
     value->Clear();
     value->Set("origins", new base::FundamentalValue(2));
     EXPECT_FALSE(Permissions::Populate(*value, &permissions_object));
@@ skipping 17 matching lines @@
     EXPECT_TRUE(permissions.get());
     EXPECT_TRUE(error.empty());
     EXPECT_TRUE(permissions->HasExplicitAccessToOrigin(GURL("http://a.com/")));
   }
 
   // Unknown permissions should throw an error.
   {
     Permissions permissions_object;
     value->Clear();
     std::unique_ptr<base::ListValue> invalid_apis(apis->DeepCopy());
-    invalid_apis->Append(new base::StringValue("unknown_permission"));
+    invalid_apis->AppendString("unknown_permission");
     value->Set("permissions", invalid_apis->DeepCopy());
     EXPECT_TRUE(Permissions::Populate(*value, &permissions_object));
     permissions = UnpackPermissionSet(permissions_object, true, &error);
     EXPECT_FALSE(permissions.get());
     EXPECT_FALSE(error.empty());
     EXPECT_EQ(error, "'unknown_permission' is not a recognized permission.");
   }
 }
 
 }  // namespace extensions