chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc ('k') | chrome/browser/extensions/api/notifications/notifications_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc b/chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc

index b20ac1a3b30d03e2a92edcfde3c5607bb8d8d177..a5078456c6f07d00cf8f2f6259dbe193f1396b2b 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc

@@ -31,7 +31,7 @@ TEST(NativeMessagingHostListPolicyHandlerTest, CheckPolicySettings) {

EXPECT_TRUE(errors.empty());

}

- list.Append(new base::StringValue("test.a.b"));

+ list.AppendString("test.a.b");

policy_map.Set(policy::key::kNativeMessagingBlacklist,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

policy::POLICY_SOURCE_CLOUD, list.CreateDeepCopy(), nullptr);

@@ -41,7 +41,7 @@ TEST(NativeMessagingHostListPolicyHandlerTest, CheckPolicySettings) {

EXPECT_TRUE(errors.empty());

}

- list.Append(new base::StringValue("*"));

+ list.AppendString("*");

policy_map.Set(policy::key::kNativeMessagingBlacklist,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

policy::POLICY_SOURCE_CLOUD, list.CreateDeepCopy(), nullptr);

@@ -51,7 +51,7 @@ TEST(NativeMessagingHostListPolicyHandlerTest, CheckPolicySettings) {

EXPECT_TRUE(errors.empty());

}

- list.Append(new base::StringValue("invalid Name"));

+ list.AppendString("invalid Name");

policy_map.Set(policy::key::kNativeMessagingBlacklist,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

policy::POLICY_SOURCE_CLOUD, list.CreateDeepCopy(), nullptr);

@@ -73,8 +73,8 @@ TEST(NativeMessagingHostListPolicyHandlerTest, ApplyPolicySettings) {

NativeMessagingHostListPolicyHandler handler(

policy::key::kNativeMessagingBlacklist, kTestPref, true);

- policy.Append(new base::StringValue("com.example.test"));

- expected.Append(new base::StringValue("com.example.test"));

+ policy.AppendString("com.example.test");

+ expected.AppendString("com.example.test");

policy_map.Set(policy::key::kNativeMessagingBlacklist,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

@@ -83,8 +83,8 @@ TEST(NativeMessagingHostListPolicyHandlerTest, ApplyPolicySettings) {

EXPECT_TRUE(prefs.GetValue(kTestPref, &value));

EXPECT_TRUE(base::Value::Equals(&expected, value));

- policy.Append(new base::StringValue("*"));

- expected.Append(new base::StringValue("*"));

+ policy.AppendString("*");

+ expected.AppendString("*");

policy_map.Set(policy::key::kNativeMessagingBlacklist,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

@@ -93,7 +93,7 @@ TEST(NativeMessagingHostListPolicyHandlerTest, ApplyPolicySettings) {

EXPECT_TRUE(prefs.GetValue(kTestPref, &value));

EXPECT_TRUE(base::Value::Equals(&expected, value));

- policy.Append(new base::StringValue("invalid Name"));

+ policy.AppendString("invalid Name");

policy_map.Set(policy::key::kNativeMessagingBlacklist,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

policy::POLICY_SOURCE_CLOUD, policy.CreateDeepCopy(), nullptr);