Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_prefs_unittest.h" 5 #include "chrome/browser/extensions/extension_prefs_unittest.h"
6 6
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket); 164 PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
165 165
166 extension_id_ = prefs_.AddExtensionAndReturnId("test"); 166 extension_id_ = prefs_.AddExtensionAndReturnId("test");
167 167
168 api_perm_set1_.insert(APIPermission::kTab); 168 api_perm_set1_.insert(APIPermission::kTab);
169 api_perm_set1_.insert(APIPermission::kBookmark); 169 api_perm_set1_.insert(APIPermission::kBookmark);
170 std::unique_ptr<APIPermission> permission( 170 std::unique_ptr<APIPermission> permission(
171 permission_info->CreateAPIPermission()); 171 permission_info->CreateAPIPermission());
172 { 172 {
173 std::unique_ptr<base::ListValue> value(new base::ListValue()); 173 std::unique_ptr<base::ListValue> value(new base::ListValue());
174 value->Append(new base::StringValue("tcp-connect:*.example.com:80")); 174 value->AppendString("tcp-connect:*.example.com:80");
175 value->Append(new base::StringValue("udp-bind::8080")); 175 value->AppendString("udp-bind::8080");
176 value->Append(new base::StringValue("udp-send-to::8888")); 176 value->AppendString("udp-send-to::8888");
177 ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL)); 177 ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
178 } 178 }
179 api_perm_set1_.insert(permission.release()); 179 api_perm_set1_.insert(permission.release());
180 180
181 api_perm_set2_.insert(APIPermission::kHistory); 181 api_perm_set2_.insert(APIPermission::kHistory);
182 182
183 AddPattern(&ehost_perm_set1_, "http://*.google.com/*"); 183 AddPattern(&ehost_perm_set1_, "http://*.google.com/*");
184 AddPattern(&ehost_perm_set1_, "http://example.com/*"); 184 AddPattern(&ehost_perm_set1_, "http://example.com/*");
185 AddPattern(&ehost_perm_set1_, "chrome://favicon/*"); 185 AddPattern(&ehost_perm_set1_, "chrome://favicon/*");
186 186
(...skipping 802 matching lines...) Expand 10 before | Expand all | Expand 10 after
989 989
990 private: 990 private:
991 std::unique_ptr<const PermissionSet> active_perms_; 991 std::unique_ptr<const PermissionSet> active_perms_;
992 scoped_refptr<Extension> component_extension_; 992 scoped_refptr<Extension> component_extension_;
993 scoped_refptr<Extension> no_component_extension_; 993 scoped_refptr<Extension> no_component_extension_;
994 }; 994 };
995 TEST_F(ExtensionPrefsComponentExtension, ExtensionPrefsComponentExtension) { 995 TEST_F(ExtensionPrefsComponentExtension, ExtensionPrefsComponentExtension) {
996 } 996 }
997 997
998 } // namespace extensions 998 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_management_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698