Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/net/predictor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/predictor.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 63 matching lines @@
 static base::ListValue* FindSerializationMotivation(
     const GURL& motivation,
     base::ListValue* referral_list) {
   return const_cast<base::ListValue*>(FindSerializationMotivation(
       motivation, static_cast<const base::ListValue*>(referral_list)));
 }
 
 // Create a new empty serialization list.
 static base::ListValue* NewEmptySerializationList() {
   base::ListValue* list = new base::ListValue;
-  list->Append(
-      new base::FundamentalValue(Predictor::kPredictorReferrerVersion));
+  list->AppendInteger(Predictor::kPredictorReferrerVersion);
   return list;
 }
 
 // Add a motivating_url and a subresource_url to a serialized list, using
 // this given latency. This is a helper function for quickly building these
 // lists.
 static void AddToSerializedList(const GURL& motivation,
                                 const GURL& subresource,
                                 double use_rate,
                                 base::ListValue* referral_list) {
   // Find the motivation if it is already used.
   base::ListValue* motivation_list = FindSerializationMotivation(motivation,
                                                            referral_list);
   if (!motivation_list) {
     // This is the first mention of this motivation, so build a list.
     motivation_list = new base::ListValue;
-    motivation_list->Append(new base::StringValue(motivation.spec()));
+    motivation_list->AppendString(motivation.spec());
     // Provide empty subresource list.
     motivation_list->Append(new base::ListValue());
 
     // ...and make it part of the serialized referral_list.
     referral_list->Append(motivation_list);
   }
 
   base::ListValue* subresource_list(NULL);
   // 0 == url; 1 == subresource_list.
   EXPECT_TRUE(motivation_list->GetList(1, &subresource_list));
 
   // We won't bother to check for the subresource being there already.  Worst
   // case, during deserialization, the latency value we supply plus the
   // existing value(s) will be added to the referrer.
 
-  subresource_list->Append(new base::StringValue(subresource.spec()));
-  subresource_list->Append(new base::FundamentalValue(use_rate));
+  subresource_list->AppendString(subresource.spec());
+  subresource_list->AppendDouble(use_rate);
 }
 
 // For a given motivation, and subresource, find what latency is currently
 // listed.  This assume a well formed serialization, which has at most one such
 // entry for any pair of names.  If no such pair is found, then return false.
 // Data is written into use_rate arguments.
 static bool GetDataFromSerialization(const GURL& motivation,
                                      const GURL& subresource,
                                      const base::ListValue& referral_list,
                                      double* use_rate) {
@@ skipping 516 matching lines @@
   testing_master.Resolve(goog, UrlInfo::OMNIBOX_MOTIVATED);
 
   // Proxy may not be in use (the PAC script has not yet been evaluated), so the
   // name has been registered for pre-resolve.
   EXPECT_FALSE(testing_master.work_queue_.IsEmpty());
 
   testing_master.Shutdown();
 }
 
 }  // namespace chrome_browser_net