Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/supervised_user_import_handler.cc ('k') | chrome/browser/ui/webui/policy_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
index f1daef9ed02ba89220e8f35e66269389a80b4a0c..0972ef4065f75189fe95e0eca6119994702a72aa 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
@@ -518,7 +518,7 @@ TEST_F(SyncSetupHandlerTest, TestSyncEverything) {
GetConfiguration(NULL, SYNC_ALL_DATA, GetAllTypes(), std::string(),
ENCRYPT_PASSWORDS, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(false));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
@@ -537,7 +537,7 @@ TEST_F(SyncSetupHandlerTest, TurnOnEncryptAll) {
GetConfiguration(NULL, SYNC_ALL_DATA, GetAllTypes(), std::string(),
ENCRYPT_ALL_DATA, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(false));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
@@ -559,7 +559,7 @@ TEST_F(SyncSetupHandlerTest, TestPassphraseStillRequired) {
GetConfiguration(NULL, SYNC_ALL_DATA, GetAllTypes(), std::string(),
ENCRYPT_PASSWORDS, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(true));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
@@ -583,7 +583,7 @@ TEST_F(SyncSetupHandlerTest, SuccessfullySetPassphrase) {
GetConfiguration(&dict, SYNC_ALL_DATA, GetAllTypes(), "gaiaPassphrase",
ENCRYPT_PASSWORDS, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
// Act as if an encryption passphrase is required the first time, then never
// again after that.
EXPECT_CALL(*mock_pss_, IsPassphraseRequired()).WillOnce(Return(true));
@@ -608,7 +608,7 @@ TEST_F(SyncSetupHandlerTest, SelectCustomEncryption) {
GetConfiguration(&dict, SYNC_ALL_DATA, GetAllTypes(), "custom_passphrase",
ENCRYPT_PASSWORDS, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(false));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
@@ -633,7 +633,7 @@ TEST_F(SyncSetupHandlerTest, UnsuccessfullySetPassphrase) {
"invalid_passphrase", ENCRYPT_PASSWORDS,
PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(true));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
@@ -671,7 +671,7 @@ TEST_F(SyncSetupHandlerTest, TestSyncIndividualTypes) {
GetConfiguration(NULL, CHOOSE_WHAT_TO_SYNC, type_to_set, std::string(),
ENCRYPT_PASSWORDS, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(false));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
@@ -692,7 +692,7 @@ TEST_F(SyncSetupHandlerTest, TestSyncAllManually) {
GetConfiguration(NULL, CHOOSE_WHAT_TO_SYNC, GetAllTypes(), std::string(),
ENCRYPT_PASSWORDS, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(false));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
@@ -932,7 +932,7 @@ TEST_F(SyncSetupHandlerTest, TurnOnEncryptAllDisallowed) {
GetConfiguration(NULL, SYNC_ALL_DATA, GetAllTypes(), std::string(),
ENCRYPT_ALL_DATA, PAYMENTS_INTEGRATION_ENABLED);
base::ListValue list_args;
- list_args.Append(new base::StringValue(args));
+ list_args.AppendString(args);
EXPECT_CALL(*mock_pss_, IsPassphraseRequiredForDecryption())
.WillRepeatedly(Return(false));
EXPECT_CALL(*mock_pss_, IsPassphraseRequired())
« no previous file with comments | « chrome/browser/ui/webui/options/supervised_user_import_handler.cc ('k') | chrome/browser/ui/webui/policy_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698