Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2888)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
index c92ef309a08be2634d71be97186f5b68d42a9e5b..b5f90280d307f8b22e24e186034a2d9318ab9513 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
@@ -85,9 +85,9 @@ TEST(ExtensionPermissionsAPIHelpers, Pack) {
// into PermissionSets.
TEST(ExtensionPermissionsAPIHelpers, Unpack) {
std::unique_ptr<base::ListValue> apis(new base::ListValue());
- apis->Append(new base::StringValue("tabs"));
+ apis->AppendString("tabs");
std::unique_ptr<base::ListValue> origins(new base::ListValue());
- origins->Append(new base::StringValue("http://a.com/*"));
+ origins->AppendString("http://a.com/*");
std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
std::unique_ptr<const PermissionSet> permissions;
@@ -121,7 +121,7 @@ TEST(ExtensionPermissionsAPIHelpers, Unpack) {
Permissions permissions_object;
value->Clear();
std::unique_ptr<base::ListValue> invalid_apis(apis->DeepCopy());
- invalid_apis->Append(new base::FundamentalValue(3));
+ invalid_apis->AppendInteger(3);
value->Set("permissions", invalid_apis->DeepCopy());
EXPECT_FALSE(Permissions::Populate(*value, &permissions_object));
}
@@ -131,7 +131,7 @@ TEST(ExtensionPermissionsAPIHelpers, Unpack) {
Permissions permissions_object;
value->Clear();
std::unique_ptr<base::ListValue> invalid_origins(origins->DeepCopy());
- invalid_origins->Append(new base::FundamentalValue(3));
+ invalid_origins->AppendInteger(3);
value->Set("origins", invalid_origins->DeepCopy());
EXPECT_FALSE(Permissions::Populate(*value, &permissions_object));
}
@@ -169,7 +169,7 @@ TEST(ExtensionPermissionsAPIHelpers, Unpack) {
Permissions permissions_object;
value->Clear();
std::unique_ptr<base::ListValue> invalid_apis(apis->DeepCopy());
- invalid_apis->Append(new base::StringValue("unknown_permission"));
+ invalid_apis->AppendString("unknown_permission");
value->Set("permissions", invalid_apis->DeepCopy());
EXPECT_TRUE(Permissions::Populate(*value, &permissions_object));
permissions = UnpackPermissionSet(permissions_object, true, &error);

Powered by Google App Engine
This is Rietveld 408576698