chrome/browser/extensions/extension_prefs_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_management_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_prefs_unittest.cc

diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc

index 151a706636ceff9bbdfe34f5cc2f9173dc4a0438..71c0d89be3e656a76a35904d4bfd9aa25805ed09 100644

--- a/chrome/browser/extensions/extension_prefs_unittest.cc

+++ b/chrome/browser/extensions/extension_prefs_unittest.cc

@@ -171,9 +171,9 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {

permission_info->CreateAPIPermission());

{

std::unique_ptr<base::ListValue> value(new base::ListValue());

- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));

- value->Append(new base::StringValue("udp-bind::8080"));

- value->Append(new base::StringValue("udp-send-to::8888"));

+ value->AppendString("tcp-connect:*.example.com:80");

+ value->AppendString("udp-bind::8080");

+ value->AppendString("udp-send-to::8888");

ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));

}

api_perm_set1_.insert(permission.release());