chrome/browser/ui/webui/options/browser_options_handler.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/invalidations_message_handler.cc ('k') | chrome/browser/ui/webui/options/certificate_manager_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/browser_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc

index a36066baaacef9b4708656324f125dec780982d4..1dd0b88bb856db4973e7b1968b965b7bf9da526e 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.cc

+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc

@@ -2001,10 +2001,10 @@ void BrowserOptionsHandler::SetupPageZoomSelector() {

base::ListValue* option = new base::ListValue();

double factor = *i;

int percent = static_cast<int>(factor * 100 + 0.5);

- option->Append(new base::StringValue(base::FormatPercent(percent)));

- option->Append(new base::FundamentalValue(factor));

+ option->AppendString(base::FormatPercent(percent));

+ option->AppendDouble(factor);

bool selected = content::ZoomValuesEqual(factor, default_zoom_factor);

- option->Append(new base::FundamentalValue(selected));

+ option->AppendBoolean(selected);

zoom_factors_value.Append(option);

}