Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc
diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
index 542ca9c5b3dce86c6a6649b8ecb2a678bd6c4dcb..238113a7c55373f1c6bb9cbc2b05f653af85414b 100644
--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
@@ -109,8 +109,8 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {
manifest.SetString(keys::kVersion, "1");
manifest.SetString(keys::kLaunchWebURL, "http://explicit/protected/start");
base::ListValue* list = new base::ListValue();
- list->Append(new base::StringValue("http://explicit/protected"));
- list->Append(new base::StringValue("*://*.wildcards/protected"));
+ list->AppendString("http://explicit/protected");
+ list->AppendString("*://*.wildcards/protected");
manifest.Set(keys::kWebURLs, list);
std::string error;
scoped_refptr<Extension> protected_app = Extension::Create(
@@ -131,11 +131,11 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {
manifest.SetString(keys::kVersion, "1");
manifest.SetString(keys::kLaunchWebURL, "http://explicit/unlimited/start");
base::ListValue* list = new base::ListValue();
- list->Append(new base::StringValue("unlimitedStorage"));
+ list->AppendString("unlimitedStorage");
manifest.Set(keys::kPermissions, list);
list = new base::ListValue();
- list->Append(new base::StringValue("http://explicit/unlimited"));
- list->Append(new base::StringValue("*://*.wildcards/unlimited"));
+ list->AppendString("http://explicit/unlimited");
+ list->AppendString("*://*.wildcards/unlimited");
manifest.Set(keys::kWebURLs, list);
std::string error;
scoped_refptr<Extension> unlimited_app = Extension::Create(
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/menu_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698