chrome/browser/ui/webui/options/options_browsertest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_browsertest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/language_options_handler_common.cc ('k') | chrome/browser/ui/webui/options/preferences_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/options_browsertest.cc

diff --git a/chrome/browser/ui/webui/options/options_browsertest.cc b/chrome/browser/ui/webui/options/options_browsertest.cc

index d964c3560e94de4b0accf90ecb475aa3227a8b71..3be96405e68790431977038e06a523bc3643eb39 100644

--- a/chrome/browser/ui/webui/options/options_browsertest.cc

+++ b/chrome/browser/ui/webui/options/options_browsertest.cc

@@ -44,7 +44,7 @@ void OptionsBrowserTest::ReportHistory(const base::ListValue* list_value) {

const int current = controller.GetCurrentEntryIndex();

for (int i = 0; i <= current; ++i) {

GURL url = controller.GetEntryAtIndex(i)->GetVirtualURL();

- history.Append(new base::StringValue(url.spec()));

+ history.AppendString(url.spec());

}

web_ui()->CallJavascriptFunction(

"OptionsWebUIExtendedTest.verifyHistoryCallback", history);