Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/sync_internals_message_handler.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc ('k') | chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/sync_internals_message_handler.cc b/chrome/browser/ui/webui/sync_internals_message_handler.cc
index 12509a26b158d5aaf5c5cf2d8b6fe19c9dc72dc4..4456aaf0675b977b1d3fc08826b57d0260da8fc2 100644
--- a/chrome/browser/ui/webui/sync_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/sync_internals_message_handler.cc
@@ -141,7 +141,7 @@ void SyncInternalsMessageHandler::HandleRequestListOfTypes(
ModelTypeSet protocol_types = syncer::ProtocolTypes();
for (ModelTypeSet::Iterator it = protocol_types.First();
it.Good(); it.Inc()) {
- type_list->Append(new base::StringValue(ModelTypeToString(it.Get())));
+ type_list->AppendString(ModelTypeToString(it.Get()));
}
event_details.Set(sync_driver::sync_ui_util::kTypes, type_list.release());
web_ui()->CallJavascriptFunction(
« no previous file with comments | « chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc ('k') | chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698