Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2209)

Unified Diff: chrome/browser/net/predictor.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/predictor.cc
diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc
index 727d8eea21048eb82859ff64a90221958894b87a..48402e95b7384b1e33685cb2d9ffafab62d02cd2 100644
--- a/chrome/browser/net/predictor.cc
+++ b/chrome/browser/net/predictor.cc
@@ -588,7 +588,7 @@ void Predictor::TrimReferrersNow() {
void Predictor::SerializeReferrers(base::ListValue* referral_list) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
referral_list->Clear();
- referral_list->Append(new base::FundamentalValue(kPredictorReferrerVersion));
+ referral_list->AppendInteger(kPredictorReferrerVersion);
for (Referrers::const_iterator it = referrers_.begin();
it != referrers_.end(); ++it) {
// Serialize the list of subresource names.
@@ -596,7 +596,7 @@ void Predictor::SerializeReferrers(base::ListValue* referral_list) {
// Create a list for each referer.
base::ListValue* motivator(new base::ListValue);
- motivator->Append(new base::StringValue(it->first.spec()));
+ motivator->AppendString(it->first.spec());
motivator->Append(subresource_list);
referral_list->Append(motivator);
@@ -1248,13 +1248,12 @@ void Predictor::InitialObserver::GetInitialDnsResolutionList(
DCHECK(startup_list);
startup_list->Clear();
DCHECK_EQ(0u, startup_list->GetSize());
- startup_list->Append(
- new base::FundamentalValue(kPredictorStartupFormatVersion));
+ startup_list->AppendInteger(kPredictorStartupFormatVersion);
for (FirstNavigations::iterator it = first_navigations_.begin();
it != first_navigations_.end();
++it) {
DCHECK(it->first == Predictor::CanonicalizeUrl(it->first));
- startup_list->Append(new base::StringValue(it->first.spec()));
+ startup_list->AppendString(it->first.spec());
}
}
« no previous file with comments | « chrome/browser/media_galleries/media_galleries_test_util.cc ('k') | chrome/browser/net/predictor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698