Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <queue>
@@ skipping 479 matching lines @@
 namespace {
 
 // Create the numerical representation of |values|, strings passed as
 // extraInfoSpec by the event handler. Returns true on success, otherwise false.
 bool GenerateInfoSpec(const std::string& values, int* result) {
   // Create a base::ListValue of strings.
   base::ListValue list_value;
   for (const std::string& cur :
        base::SplitString(values, ",", base::KEEP_WHITESPACE,
                          base::SPLIT_WANT_NONEMPTY))
-    list_value.Append(new base::StringValue(cur));
+    list_value.AppendString(cur);
   return ExtraInfoSpec::InitFromValue(list_value, result);
 }
 
 }  // namespace
 
 void ExtensionWebRequestTest::FireURLRequestWithData(
     const std::string& method,
     const char* content_type,
     const std::vector<char>& bytes_1,
     const std::vector<char>& bytes_2) {
@@ skipping 744 matching lines @@
       new EventResponseDelta("ext_1", base::Time::FromInternalValue(0)));
   linked_ptr<EventResponseDelta> b(
       new EventResponseDelta("ext_2", base::Time::FromInternalValue(1000)));
   EXPECT_FALSE(InDecreasingExtensionInstallationTimeOrder(a, a));
   EXPECT_FALSE(InDecreasingExtensionInstallationTimeOrder(a, b));
   EXPECT_TRUE(InDecreasingExtensionInstallationTimeOrder(b, a));
 }
 
 TEST(ExtensionWebRequestHelpersTest, TestStringToCharList) {
   base::ListValue list_value;
-  list_value.Append(new base::FundamentalValue('1'));
-  list_value.Append(new base::FundamentalValue('2'));
-  list_value.Append(new base::FundamentalValue('3'));
-  list_value.Append(new base::FundamentalValue(0xFE));
-  list_value.Append(new base::FundamentalValue(0xD1));
+  list_value.AppendInteger('1');
+  list_value.AppendInteger('2');
+  list_value.AppendInteger('3');
+  list_value.AppendInteger(0xFE);
+  list_value.AppendInteger(0xD1);
 
   unsigned char char_value[] = {'1', '2', '3', 0xFE, 0xD1};
   std::string string_value(reinterpret_cast<char *>(char_value), 5);
 
   std::unique_ptr<base::ListValue> converted_list(
       StringToCharList(string_value));
   EXPECT_TRUE(list_value.Equals(converted_list.get()));
 
   std::string converted_string;
   EXPECT_TRUE(CharListToString(&list_value, &converted_string));
@@ skipping 1034 matching lines @@
   EXPECT_TRUE(credentials_set);
   EXPECT_FALSE(auth3.Empty());
   EXPECT_EQ(username, auth1.username());
   EXPECT_EQ(password, auth1.password());
   EXPECT_EQ(1u, warning_set.size());
   EXPECT_TRUE(HasWarning(warning_set, "extid2"));
   EXPECT_EQ(3u, capturing_net_log.GetSize());
 }
 
 }  // namespace extensions