Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2863)

Unified Diff: chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc b/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
index 6ae212ff3adadbcd2d42b09764fd413d5bd20cbb..c90a10674d0c38b4686dc6936ec646bfeccac19a 100644
--- a/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
@@ -96,7 +96,7 @@ class ProfileInfoHandlerTest : public testing::Test {
TEST_F(ProfileInfoHandlerTest, GetProfileInfo) {
base::ListValue list_args;
- list_args.Append(new base::StringValue("get-profile-info-callback-id"));
+ list_args.AppendString("get-profile-info-callback-id");
handler()->HandleGetProfileInfo(&list_args);
EXPECT_EQ(1U, web_ui()->call_data().size());
@@ -117,7 +117,7 @@ TEST_F(ProfileInfoHandlerTest, GetProfileInfo) {
TEST_F(ProfileInfoHandlerTest, PushProfileInfo) {
base::ListValue list_args;
- list_args.Append(new base::StringValue("get-profile-info-callback-id"));
+ list_args.AppendString("get-profile-info-callback-id");
handler()->HandleGetProfileInfo(&list_args);
handler()->OnProfileAvatarChanged(base::FilePath());

Powered by Google App Engine
This is Rietveld 408576698