Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/extensions/extension_management_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management.h"
 
 #include <algorithm>
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 719 matching lines @@
   EXPECT_FALSE(extension_management_->IsInstallationExplicitlyAllowed(blocked));
   EXPECT_FALSE(
       extension_management_->IsInstallationExplicitlyAllowed(not_specified));
 }
 
 // Tests the flag value indicating that extensions are blacklisted by default.
 TEST_F(ExtensionAdminPolicyTest, BlacklistedByDefault) {
   EXPECT_FALSE(BlacklistedByDefault(NULL));
 
   base::ListValue blacklist;
-  blacklist.Append(new base::StringValue(kNonExistingExtension));
+  blacklist.AppendString(kNonExistingExtension);
   EXPECT_FALSE(BlacklistedByDefault(&blacklist));
-  blacklist.Append(new base::StringValue("*"));
+  blacklist.AppendString("*");
   EXPECT_TRUE(BlacklistedByDefault(&blacklist));
 
   blacklist.Clear();
-  blacklist.Append(new base::StringValue("*"));
+  blacklist.AppendString("*");
   EXPECT_TRUE(BlacklistedByDefault(&blacklist));
 }
 
 // Tests UserMayLoad for required extensions.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadRequired) {
   CreateExtension(Manifest::COMPONENT);
   EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), NULL));
   base::string16 error;
   EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 
   // Required extensions may load even if they're on the blacklist.
   base::ListValue blacklist;
-  blacklist.Append(new base::StringValue(extension_->id()));
+  blacklist.AppendString(extension_->id());
   EXPECT_TRUE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
 
-  blacklist.Append(new base::StringValue("*"));
+  blacklist.AppendString("*");
   EXPECT_TRUE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
 }
 
 // Tests UserMayLoad when no blacklist exists, or it's empty.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadNoBlacklist) {
   CreateExtension(Manifest::INTERNAL);
   EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), NULL));
   base::ListValue blacklist;
   EXPECT_TRUE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
   base::string16 error;
   EXPECT_TRUE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 }
 
 // Tests UserMayLoad for an extension on the whitelist.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadWhitelisted) {
   CreateExtension(Manifest::INTERNAL);
 
   base::ListValue whitelist;
-  whitelist.Append(new base::StringValue(extension_->id()));
+  whitelist.AppendString(extension_->id());
   EXPECT_TRUE(
       UserMayLoad(NULL, &whitelist, NULL, NULL, extension_.get(), NULL));
 
   base::ListValue blacklist;
-  blacklist.Append(new base::StringValue(extension_->id()));
+  blacklist.AppendString(extension_->id());
   EXPECT_TRUE(
       UserMayLoad(NULL, &whitelist, NULL, NULL, extension_.get(), NULL));
   base::string16 error;
   EXPECT_TRUE(
       UserMayLoad(NULL, &whitelist, NULL, NULL, extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 }
 
 // Tests UserMayLoad for an extension on the blacklist.
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadBlacklisted) {
   CreateExtension(Manifest::INTERNAL);
 
   // Blacklisted by default.
   base::ListValue blacklist;
-  blacklist.Append(new base::StringValue("*"));
+  blacklist.AppendString("*");
   EXPECT_FALSE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
   base::string16 error;
   EXPECT_FALSE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), &error));
   EXPECT_FALSE(error.empty());
 
   // Extension on the blacklist, with and without wildcard.
-  blacklist.Append(new base::StringValue(extension_->id()));
+  blacklist.AppendString(extension_->id());
   EXPECT_FALSE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
   blacklist.Clear();
-  blacklist.Append(new base::StringValue(extension_->id()));
+  blacklist.AppendString(extension_->id());
   EXPECT_FALSE(
       UserMayLoad(&blacklist, NULL, NULL, NULL, extension_.get(), NULL));
 
   // With a whitelist. There's no such thing as a whitelist wildcard.
   base::ListValue whitelist;
-  whitelist.Append(new base::StringValue("behllobkkfkfnphdnhnkndlbkcpglgmj"));
+  whitelist.AppendString("behllobkkfkfnphdnhnkndlbkcpglgmj");
   EXPECT_FALSE(
       UserMayLoad(&blacklist, &whitelist, NULL, NULL, extension_.get(), NULL));
-  whitelist.Append(new base::StringValue("*"));
+  whitelist.AppendString("*");
   EXPECT_FALSE(
       UserMayLoad(&blacklist, &whitelist, NULL, NULL, extension_.get(), NULL));
 }
 
 TEST_F(ExtensionAdminPolicyTest, UserMayLoadAllowedTypes) {
   CreateExtension(Manifest::INTERNAL);
   EXPECT_TRUE(UserMayLoad(NULL, NULL, NULL, NULL, extension_.get(), NULL));
 
   base::ListValue allowed_types;
   EXPECT_FALSE(
@@ skipping 34 matching lines @@
   EXPECT_FALSE(error.empty());
 
   CreateExtension(Manifest::INTERNAL);
   error.clear();
   EXPECT_FALSE(MustRemainEnabled(extension_.get(), NULL));
   EXPECT_FALSE(MustRemainEnabled(extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 }
 
 }  // namespace extensions