chrome/browser/extensions/menu_manager_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy_unittest.cc ('k') | chrome/browser/extensions/policy_handlers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager_unittest.cc

diff --git a/chrome/browser/extensions/menu_manager_unittest.cc b/chrome/browser/extensions/menu_manager_unittest.cc

index daac058a768f0ee6812cb7bc97585848a4818747..a4c41884cba7613193d4fc45797bfce2063db6ad 100644

--- a/chrome/browser/extensions/menu_manager_unittest.cc

+++ b/chrome/browser/extensions/menu_manager_unittest.cc

@@ -225,16 +225,12 @@ TEST_F(MenuManagerTest, PopulateFromValue) {

ASSERT_TRUE(contexts.ToValue()->GetAsInteger(&contexts_value));

base::ListValue* document_url_patterns(new base::ListValue());

- document_url_patterns->Append(

- new base::StringValue("http://www.google.com/*"));

- document_url_patterns->Append(

- new base::StringValue("http://www.reddit.com/*"));

+ document_url_patterns->AppendString("http://www.google.com/*");

+ document_url_patterns->AppendString("http://www.reddit.com/*");

base::ListValue* target_url_patterns(new base::ListValue());

- target_url_patterns->Append(

- new base::StringValue("http://www.yahoo.com/*"));

- target_url_patterns->Append(

- new base::StringValue("http://www.facebook.com/*"));

+ target_url_patterns->AppendString("http://www.yahoo.com/*");

+ target_url_patterns->AppendString("http://www.facebook.com/*");

base::DictionaryValue value;

value.SetBoolean("incognito", incognito);