Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/ui/webui/options/font_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/font_settings_handler.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 190 matching lines @@
     std::unique_ptr<base::ListValue> list) {
   // Selects the directionality for the fonts in the given list.
   for (size_t i = 0; i < list->GetSize(); i++) {
     base::ListValue* font;
     bool has_font = list->GetList(i, &font);
     DCHECK(has_font);
     base::string16 value;
     bool has_value = font->GetString(1, &value);
     DCHECK(has_value);
     bool has_rtl_chars = base::i18n::StringContainsStrongRTLChars(value);
-    font->Append(new base::StringValue(has_rtl_chars ? "rtl" : "ltr"));
+    font->AppendString(has_rtl_chars ? "rtl" : "ltr");
   }
 
   base::ListValue encoding_list;
   const std::vector<CharacterEncoding::EncodingInfo>* encodings;
   PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
   encodings = CharacterEncoding::GetCurrentDisplayEncodings(
       g_browser_process->GetApplicationLocale(),
       pref_service->GetString(prefs::kStaticEncodings),
       pref_service->GetString(prefs::kRecentlySelectedEncoding));
   DCHECK(encodings);
   DCHECK(!encodings->empty());
 
   std::vector<CharacterEncoding::EncodingInfo>::const_iterator it;
   for (it = encodings->begin(); it != encodings->end(); ++it) {
     base::ListValue* option = new base::ListValue();
     if (it->encoding_id) {
       int cmd_id = it->encoding_id;
       std::string encoding =
       CharacterEncoding::GetCanonicalEncodingNameByCommandId(cmd_id);
       base::string16 name = it->encoding_display_name;
       bool has_rtl_chars = base::i18n::StringContainsStrongRTLChars(name);
-      option->Append(new base::StringValue(encoding));
-      option->Append(new base::StringValue(name));
-      option->Append(new base::StringValue(has_rtl_chars ? "rtl" : "ltr"));
+      option->AppendString(encoding);
+      option->AppendString(name);
+      option->AppendString(has_rtl_chars ? "rtl" : "ltr");
     } else {
       // Add empty name/value to indicate a separator item.
-      option->Append(new base::StringValue(std::string()));
-      option->Append(new base::StringValue(std::string()));
+      option->AppendString(std::string());
+      option->AppendString(std::string());
     }
     encoding_list.Append(option);
   }
 
   base::ListValue selected_values;
-  selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
-      standard_font_.GetValue())));
-  selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
-      serif_font_.GetValue())));
-  selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
-      sans_serif_font_.GetValue())));
-  selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
-      fixed_font_.GetValue())));
-  selected_values.Append(new base::StringValue(font_encoding_.GetValue()));
+  selected_values.AppendString(
+      MaybeGetLocalizedFontName(standard_font_.GetValue()));
+  selected_values.AppendString(
+      MaybeGetLocalizedFontName(serif_font_.GetValue()));
+  selected_values.AppendString(
+      MaybeGetLocalizedFontName(sans_serif_font_.GetValue()));
+  selected_values.AppendString(
+      MaybeGetLocalizedFontName(fixed_font_.GetValue()));
+  selected_values.AppendString(font_encoding_.GetValue());
 
   web_ui()->CallJavascriptFunction("FontSettings.setFontsData",
                                    *list.get(), encoding_list,
                                    selected_values);
 }
 
 void FontSettingsHandler::SetUpStandardFontSample() {
   base::StringValue font_value(standard_font_.GetValue());
   base::FundamentalValue size_value(default_font_size_.GetValue());
   web_ui()->CallJavascriptFunction(
@@ skipping 52 matching lines @@
       chrome::FindBrowserWithWebContents(web_ui()->GetWebContents()));
 }
 
 void FontSettingsHandler::OnWebKitDefaultFontSizeChanged() {
   SetUpStandardFontSample();
   SetUpSerifFontSample();
   SetUpSansSerifFontSample();
 }
 
 }  // namespace options