chrome/browser/ui/webui/options/language_options_handler_common.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/handler_options_handler.cc ('k') | chrome/browser/ui/webui/options/options_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/language_options_handler_common.cc

diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc

index 6d3c400a9aa862f790c76dac15f4f77252d755b6..f654322c49089b8ee7767e5987fcae60b00d7be8 100644

--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc

+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc

@@ -138,7 +138,7 @@ void LanguageOptionsHandlerCommon::GetLocalizedValues(

base::ListValue* languages_list = new base::ListValue();

for (std::vector<std::string>::iterator it = languages.begin();

it != languages.end(); ++it) {

- languages_list->Append(new base::StringValue(*it));

+ languages_list->AppendString(*it);

}

localized_strings->Set("translateSupportedLanguages", languages_list);