chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/sync_internals_message_handler.cc ('k') | chrome/common/extensions/api/common_extension_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

index ccf799c23b10027813a1d650626828f520b43cb7..8928f5704fa80792720ca057041dd5a6b0056c42 100644

--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

@@ -232,9 +232,9 @@ void TranslateInternalsHandler::SendSupportedLanguagesToJs() {

for (std::vector<std::string>::iterator it = languages.begin();

it != languages.end(); ++it) {

const std::string& lang = *it;

- languages_list->Append(new base::StringValue(lang));

+ languages_list->AppendString(lang);

if (translate::TranslateDownloadManager::IsAlphaLanguage(lang))

- alpha_languages_list->Append(new base::StringValue(lang));

+ alpha_languages_list->AppendString(lang);

}

dict.Set("languages", languages_list);