chrome/browser/content_settings/content_settings_policy_provider_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_application_list_model_unittest.cc ('k') | chrome/browser/download/download_query_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

index f287af6eb1d1e0e08634d60f4823112188387a39..dfd3cc71c79bd40c23d56499f01c1775dfc1c106 100644

--- a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

@@ -123,7 +123,7 @@ TEST_F(PolicyProviderTest, GettingManagedContentSettings) {

profile.GetTestingPrefService();

base::ListValue* value = new base::ListValue();

- value->Append(new base::StringValue("[*.]google.com"));

+ value->AppendString("[*.]google.com");

prefs->SetManagedPref(prefs::kManagedImagesBlockedForUrls,

value);

@@ -179,7 +179,7 @@ TEST_F(PolicyProviderTest, ResourceIdentifier) {

profile.GetTestingPrefService();

base::ListValue* value = new base::ListValue();

- value->Append(new base::StringValue("[*.]google.com"));

+ value->AppendString("[*.]google.com");

prefs->SetManagedPref(prefs::kManagedPluginsAllowedForUrls,

value);

@@ -226,8 +226,7 @@ TEST_F(PolicyProviderTest, AutoSelectCertificateList) {

std::string pattern_str("\"pattern\":\"[*.]google.com\"");

std::string filter_str("\"filter\":{\"ISSUER\":{\"CN\":\"issuer name\"}}");

base::ListValue* value = new base::ListValue();

- value->Append(

- new base::StringValue("{" + pattern_str + "," + filter_str + "}"));

+ value->AppendString("{" + pattern_str + "," + filter_str + "}");

prefs->SetManagedPref(prefs::kManagedAutoSelectCertificateForUrls,

value);

GURL youtube_url("https://www.youtube.com");