Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/extensions/api/notifications/notifications_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/notifications/notifications_api.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 140 matching lines @@
         ShutdownNotifierFactory::GetInstance()->Get(profile)->Subscribe(
             base::Bind(&NotificationsApiDelegate::Shutdown,
                        base::Unretained(this)));
   }
 
   void Close(bool by_user) override {
     EventRouter::UserGestureState gesture =
         by_user ? EventRouter::USER_GESTURE_ENABLED
                 : EventRouter::USER_GESTURE_NOT_ENABLED;
     std::unique_ptr<base::ListValue> args(CreateBaseEventArgs());
-    args->Append(new base::FundamentalValue(by_user));
+    args->AppendBoolean(by_user);
     SendEvent(events::NOTIFICATIONS_ON_CLOSED,
               notifications::OnClosed::kEventName, gesture, std::move(args));
   }
 
   void Click() override {
     std::unique_ptr<base::ListValue> args(CreateBaseEventArgs());
     SendEvent(events::NOTIFICATIONS_ON_CLICKED,
               notifications::OnClicked::kEventName,
               EventRouter::USER_GESTURE_ENABLED, std::move(args));
   }
 
   bool HasClickedListener() override {
     if (!event_router_)
       return false;
 
     return event_router_->HasEventListener(
         notifications::OnClicked::kEventName);
   }
 
   void ButtonClick(int index) override {
     std::unique_ptr<base::ListValue> args(CreateBaseEventArgs());
-    args->Append(new base::FundamentalValue(index));
+    args->AppendInteger(index);
     SendEvent(events::NOTIFICATIONS_ON_BUTTON_CLICKED,
               notifications::OnButtonClicked::kEventName,
               EventRouter::USER_GESTURE_ENABLED, std::move(args));
   }
 
   std::string id() const override { return scoped_id_; }
 
  private:
   ~NotificationsApiDelegate() override {}
 
@@ skipping 10 matching lines @@
     event_router_->DispatchEventToExtension(extension_id_, std::move(event));
   }
 
   void Shutdown() {
     event_router_ = nullptr;
     shutdown_notifier_subscription_.reset();
   }
 
   std::unique_ptr<base::ListValue> CreateBaseEventArgs() {
     std::unique_ptr<base::ListValue> args(new base::ListValue());
-    args->Append(new base::StringValue(id_));
+    args->AppendString(id_);
     return args;
   }
 
   scoped_refptr<ChromeAsyncExtensionFunction> api_function_;
 
   // Since this class is refcounted it may outlive the profile.  We listen for
   // profile-keyed service shutdown events and reset to nullptr at that time,
   // so make sure to check for a valid pointer before use.
   EventRouter* event_router_;
 
@@ skipping 497 matching lines @@
           : api::notifications::PERMISSION_LEVEL_DENIED;
 
   SetResult(base::MakeUnique<base::StringValue>(
       api::notifications::ToString(result)));
   SendResponse(true);
 
   return true;
 }
 
 }  // namespace extensions