Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3075)

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index 0ea9014511de33e706b6efc0cff44c9568de39fd..004947936ed4e219d9ffabea26f6f13dc601dd4a 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -364,7 +364,7 @@ Status ExecuteSwitchToFrame(Session* session,
} else {
return Status(kUnknownError, "invalid 'id'");
}
- args.Append(new base::StringValue(xpath));
+ args.AppendString(xpath);
}
std::string frame;
Status status = web_view->GetFrameByFunction(
@@ -750,7 +750,7 @@ Status ExecuteGetStorageItem(const char* storage,
if (!params.GetString("key", &key))
return Status(kUnknownError, "'key' must be a string");
base::ListValue args;
- args.Append(new base::StringValue(key));
+ args.AppendString(key);
return web_view->CallFunction(
session->GetCurrentFrameId(),
base::StringPrintf("function(key) { return %s[key]; }", storage),
@@ -789,8 +789,8 @@ Status ExecuteSetStorageItem(const char* storage,
if (!params.GetString("value", &storage_value))
return Status(kUnknownError, "'value' must be a string");
base::ListValue args;
- args.Append(new base::StringValue(key));
- args.Append(new base::StringValue(storage_value));
+ args.AppendString(key);
+ args.AppendString(storage_value);
return web_view->CallFunction(
session->GetCurrentFrameId(),
base::StringPrintf("function(key, value) { %s[key] = value; }", storage),
@@ -808,7 +808,7 @@ Status ExecuteRemoveStorageItem(const char* storage,
if (!params.GetString("key", &key))
return Status(kUnknownError, "'key' must be a string");
base::ListValue args;
- args.Append(new base::StringValue(key));
+ args.AppendString(key);
return web_view->CallFunction(
session->GetCurrentFrameId(),
base::StringPrintf("function(key) { %s.removeItem(key) }", storage),
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698