Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/content_settings/core/browser/content_settings_policy_provider.h"
 
 #include <memory>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 105 matching lines @@
   prefs->RemoveManagedPref(prefs::kManagedDefaultImagesSetting);
   provider.ShutdownOnUIThread();
 }
 
 TEST_F(PolicyProviderTest, GettingManagedContentSettings) {
   TestingProfile profile;
   syncable_prefs::TestingPrefServiceSyncable* prefs =
       profile.GetTestingPrefService();
 
   base::ListValue* value = new base::ListValue();
-  value->Append(new base::StringValue("[*.]google.com"));
+  value->AppendString("[*.]google.com");
   prefs->SetManagedPref(prefs::kManagedImagesBlockedForUrls,
                         value);
 
   PolicyProvider provider(prefs);
 
   ContentSettingsPattern yt_url_pattern =
       ContentSettingsPattern::FromString("www.youtube.com");
   GURL youtube_url("http://www.youtube.com");
   GURL google_url("http://mail.google.com");
 
@@ skipping 35 matching lines @@
 
   provider.ShutdownOnUIThread();
 }
 
 TEST_F(PolicyProviderTest, ResourceIdentifier) {
   TestingProfile profile;
   syncable_prefs::TestingPrefServiceSyncable* prefs =
       profile.GetTestingPrefService();
 
   base::ListValue* value = new base::ListValue();
-  value->Append(new base::StringValue("[*.]google.com"));
+  value->AppendString("[*.]google.com");
   prefs->SetManagedPref(prefs::kManagedPluginsAllowedForUrls,
                         value);
 
   PolicyProvider provider(prefs);
 
   GURL youtube_url("http://www.youtube.com");
   GURL google_url("http://mail.google.com");
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
             TestUtils::GetContentSetting(&provider, youtube_url, youtube_url,
@@ skipping 26 matching lines @@
   EXPECT_EQ(NULL, TestUtils::GetContentSettingValue(
                       &provider, google_url, google_url,
                       CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE,
                       std::string(), false));
 
   // Set the content settings pattern list for origins to auto select
   // certificates.
   std::string pattern_str("\"pattern\":\"[*.]google.com\"");
   std::string filter_str("\"filter\":{\"ISSUER\":{\"CN\":\"issuer name\"}}");
   base::ListValue* value = new base::ListValue();
-  value->Append(
-      new base::StringValue("{" + pattern_str + "," + filter_str + "}"));
+  value->AppendString("{" + pattern_str + "," + filter_str + "}");
   prefs->SetManagedPref(prefs::kManagedAutoSelectCertificateForUrls,
                         value);
   GURL youtube_url("https://www.youtube.com");
   EXPECT_EQ(NULL, TestUtils::GetContentSettingValue(
                       &provider, youtube_url, youtube_url,
                       CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE,
                       std::string(), false));
   std::unique_ptr<base::Value> cert_filter(TestUtils::GetContentSettingValue(
       &provider, google_url, google_url,
       CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE, std::string(), false));
 
   ASSERT_EQ(base::Value::TYPE_DICTIONARY, cert_filter->GetType());
   base::DictionaryValue* dict_value =
       static_cast<base::DictionaryValue*>(cert_filter.get());
   std::string actual_common_name;
   ASSERT_TRUE(dict_value->GetString("ISSUER.CN", &actual_common_name));
   EXPECT_EQ("issuer name", actual_common_name);
   provider.ShutdownOnUIThread();
 }
 
 }  // namespace content_settings