chrome/browser/extensions/extension_service_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_prefs_unittest.cc ('k') | chrome/browser/extensions/extension_special_storage_policy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index 76212643f7420042f0f4f85eca7bbe195cb2dc0f..cf0d1b91079696e86414055ae6efc9bc2e729735 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -747,7 +747,7 @@ class ExtensionServiceTest

base::ListValue* list_value = new base::ListValue();

for (std::set<std::string>::const_iterator iter = value.begin();

iter != value.end(); ++iter)

- list_value->Append(new base::StringValue(*iter));

+ list_value->AppendString(*iter);

SetPref(extension_id, pref_path, list_value, msg);

}

@@ -1644,8 +1644,7 @@ TEST_F(ExtensionServiceTest, GrantedAPIAndHostPermissions) {

host_permissions.insert("http://*.google.com.hk/*");

base::ListValue* api_permissions = new base::ListValue();

- api_permissions->Append(

- new base::StringValue("tabs"));

+ api_permissions->AppendString("tabs");

SetPref(extension_id, "granted_permissions.api",

api_permissions, "granted_permissions.api");

SetPrefStringSet(