chrome/common/extensions/api/common_extension_api_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/common_extension_api_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc ('k') | chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/common_extension_api_unittest.cc

diff --git a/chrome/common/extensions/api/common_extension_api_unittest.cc b/chrome/common/extensions/api/common_extension_api_unittest.cc

index d8a9555ae48191a6c0a8bbb4be83a14a51871ac8..d24fd46b65fe1cd91f2cc0e1c29dae2a23dacdee 100644

--- a/chrome/common/extensions/api/common_extension_api_unittest.cc

+++ b/chrome/common/extensions/api/common_extension_api_unittest.cc

@@ -325,7 +325,7 @@ scoped_refptr<Extension> CreateExtensionWithPermissions(

std::unique_ptr<base::ListValue> permissions_list(new base::ListValue());

for (std::set<std::string>::const_iterator i = permissions.begin();

i != permissions.end(); ++i) {

- permissions_list->Append(new base::StringValue(*i));

+ permissions_list->AppendString(*i);

}

manifest.Set("permissions", permissions_list.release());

}

@@ -444,7 +444,7 @@ scoped_refptr<Extension> CreatePackagedAppWithPermissions(

base::DictionaryValue* app = new base::DictionaryValue();

base::DictionaryValue* background = new base::DictionaryValue();

base::ListValue* scripts = new base::ListValue();

- scripts->Append(new base::StringValue("test.js"));

+ scripts->AppendString("test.js");

background->Set("scripts", scripts);

app->Set("background", background);

values.Set(manifest_keys::kApp, app);

@@ -452,7 +452,7 @@ scoped_refptr<Extension> CreatePackagedAppWithPermissions(

std::unique_ptr<base::ListValue> permissions_list(new base::ListValue());

for (std::set<std::string>::const_iterator i = permissions.begin();

i != permissions.end(); ++i) {

- permissions_list->Append(new base::StringValue(*i));

+ permissions_list->AppendString(*i);

}

values.Set("permissions", permissions_list.release());

}

@@ -685,7 +685,7 @@ TEST(ExtensionAPITest, FeaturesRequireContexts) {

base::DictionaryValue* test1 = new base::DictionaryValue();

base::DictionaryValue* test2 = new base::DictionaryValue();

base::ListValue* contexts = new base::ListValue();

- contexts->Append(new base::StringValue("content_script"));

+ contexts->AppendString("content_script");

test1->Set("contexts", contexts);

test1->SetString("channel", "stable");

test2->SetString("channel", "stable");