Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/common/extensions/api/common_extension_api_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_api.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 307 matching lines @@
 scoped_refptr<Extension> CreateExtensionWithPermissions(
     const std::set<std::string>& permissions) {
   base::DictionaryValue manifest;
   manifest.SetString("name", "extension");
   manifest.SetString("version", "1.0");
   manifest.SetInteger("manifest_version", 2);
   {
     std::unique_ptr<base::ListValue> permissions_list(new base::ListValue());
     for (std::set<std::string>::const_iterator i = permissions.begin();
         i != permissions.end(); ++i) {
-      permissions_list->Append(new base::StringValue(*i));
+      permissions_list->AppendString(*i);
     }
     manifest.Set("permissions", permissions_list.release());
   }
 
   std::string error;
   scoped_refptr<Extension> extension(Extension::Create(
       base::FilePath(), Manifest::UNPACKED,
       manifest, Extension::NO_FLAGS, &error));
   CHECK(extension.get());
   CHECK(error.empty());
@@ skipping 98 matching lines @@
     const std::set<std::string>& permissions) {
   base::DictionaryValue values;
   values.SetString(manifest_keys::kName, "test");
   values.SetString(manifest_keys::kVersion, "0.1");
   values.SetString(manifest_keys::kPlatformAppBackground,
       "http://www.example.com");
 
   base::DictionaryValue* app = new base::DictionaryValue();
   base::DictionaryValue* background = new base::DictionaryValue();
   base::ListValue* scripts = new base::ListValue();
-  scripts->Append(new base::StringValue("test.js"));
+  scripts->AppendString("test.js");
   background->Set("scripts", scripts);
   app->Set("background", background);
   values.Set(manifest_keys::kApp, app);
   {
     std::unique_ptr<base::ListValue> permissions_list(new base::ListValue());
     for (std::set<std::string>::const_iterator i = permissions.begin();
         i != permissions.end(); ++i) {
-      permissions_list->Append(new base::StringValue(*i));
+      permissions_list->AppendString(*i);
     }
     values.Set("permissions", permissions_list.release());
   }
 
   std::string error;
   scoped_refptr<Extension> extension(Extension::Create(
       base::FilePath(), Manifest::INTERNAL, values, Extension::NO_FLAGS,
       &error));
   CHECK(extension.get()) << error;
   return extension;
@@ skipping 212 matching lines @@
 
 TEST(ExtensionAPITest, FeaturesRequireContexts) {
   // TODO(cduvall): Make this check API featues.
   std::unique_ptr<base::DictionaryValue> api_features1(
       new base::DictionaryValue());
   std::unique_ptr<base::DictionaryValue> api_features2(
       new base::DictionaryValue());
   base::DictionaryValue* test1 = new base::DictionaryValue();
   base::DictionaryValue* test2 = new base::DictionaryValue();
   base::ListValue* contexts = new base::ListValue();
-  contexts->Append(new base::StringValue("content_script"));
+  contexts->AppendString("content_script");
   test1->Set("contexts", contexts);
   test1->SetString("channel", "stable");
   test2->SetString("channel", "stable");
   api_features1->Set("test", test1);
   api_features2->Set("test", test2);
 
   struct {
     base::DictionaryValue* api_features;
     bool expect_success;
   } test_data[] = {
@@ skipping 156 matching lines @@
                                          extension.get(),
                                          Feature::BLESSED_EXTENSION_CONTEXT,
                                          GURL()).is_available());
   EXPECT_FALSE(extension_api->IsAvailable("pageAction",
                                           extension.get(),
                                           Feature::BLESSED_EXTENSION_CONTEXT,
                                           GURL()).is_available());
 }
 
 }  // namespace extensions