chrome/browser/ui/startup/startup_browser_creator_browsertest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

index 9eff3b26aa3e74889aac6699db4b8bc8f80a35de..5a5e29c367a1ca3b1c7b11e8bee3aafa90449d04 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

@@ -1548,8 +1548,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,

new base::FundamentalValue(SessionStartupPref::kPrefValueURLs)),

nullptr);

base::ListValue startup_urls;

- startup_urls.Append(new base::StringValue(

- embedded_test_server()->GetURL("/title1.html").spec()));

+ startup_urls.AppendString(

+ embedded_test_server()->GetURL("/title1.html").spec());

policy_map_.Set(policy::key::kRestoreOnStartupURLs,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

policy::POLICY_SOURCE_CLOUD, startup_urls.CreateDeepCopy(),

« no previous file with comments | « chrome/browser/tracing/chrome_tracing_delegate.cc ('k') | chrome/browser/ui/webui/invalidations_message_handler.cc » ('j') | no next file with comments »