chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/windows_event_router.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

index 69d017a84900a91e6b069122fa6cabddd9796e0f..9065ac4e85f292ea8ba3af6b0310e53420029f4a 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

@@ -121,13 +121,13 @@ void DispatchOnCommitted(events::HistogramValue histogram_value,

dict->SetString(keys::kTransitionTypeKey, transition_type_string);

base::ListValue* qualifiers = new base::ListValue();

if (transition_type & ui::PAGE_TRANSITION_CLIENT_REDIRECT)

- qualifiers->Append(new base::StringValue("client_redirect"));

+ qualifiers->AppendString("client_redirect");

if (transition_type & ui::PAGE_TRANSITION_SERVER_REDIRECT)

- qualifiers->Append(new base::StringValue("server_redirect"));

+ qualifiers->AppendString("server_redirect");

if (transition_type & ui::PAGE_TRANSITION_FORWARD_BACK)

- qualifiers->Append(new base::StringValue("forward_back"));

+ qualifiers->AppendString("forward_back");

if (transition_type & ui::PAGE_TRANSITION_FROM_ADDRESS_BAR)

- qualifiers->Append(new base::StringValue("from_address_bar"));

+ qualifiers->AppendString("from_address_bar");

dict->Set(keys::kTransitionQualifiersKey, qualifiers);

dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));

args->Append(dict);