Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: chrome/browser/media_galleries/media_galleries_test_util.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer_unittest.cc ('k') | chrome/browser/net/predictor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_galleries/media_galleries_test_util.cc
diff --git a/chrome/browser/media_galleries/media_galleries_test_util.cc b/chrome/browser/media_galleries/media_galleries_test_util.cc
index cb66f989a260e6e28a46cbe4f8182663eb1ce29d..198446ff2f40933b9c91fc7a3257456a230580d9 100644
--- a/chrome/browser/media_galleries/media_galleries_test_util.cc
+++ b/chrome/browser/media_galleries/media_galleries_test_util.cc
@@ -45,14 +45,13 @@ scoped_refptr<extensions::Extension> AddMediaGalleriesApp(
manifest->SetString(extensions::manifest_keys::kVersion, "0.1");
manifest->SetInteger(extensions::manifest_keys::kManifestVersion, 2);
base::ListValue* background_script_list = new base::ListValue;
- background_script_list->Append(new base::StringValue("background.js"));
+ background_script_list->AppendString("background.js");
manifest->Set(extensions::manifest_keys::kPlatformAppBackgroundScripts,
background_script_list);
base::ListValue* permission_detail_list = new base::ListValue;
for (size_t i = 0; i < media_galleries_permissions.size(); i++)
- permission_detail_list->Append(
- new base::StringValue(media_galleries_permissions[i]));
+ permission_detail_list->AppendString(media_galleries_permissions[i]);
base::DictionaryValue* media_galleries_permission =
new base::DictionaryValue();
media_galleries_permission->Set("mediaGalleries", permission_detail_list);
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer_unittest.cc ('k') | chrome/browser/net/predictor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698