chrome/browser/ui/webui/options/preferences_browsertest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/preferences_browsertest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/options_browsertest.cc ('k') | chrome/browser/ui/webui/options/supervised_user_import_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/preferences_browsertest.cc

diff --git a/chrome/browser/ui/webui/options/preferences_browsertest.cc b/chrome/browser/ui/webui/options/preferences_browsertest.cc

index 5a76e3d13f58a6b71aae6b30a9e7b92df6af40e3..56ab9ec9dd0a8f5e678bd222b86885736b88e14f 100644

--- a/chrome/browser/ui/webui/options/preferences_browsertest.cc

+++ b/chrome/browser/ui/webui/options/preferences_browsertest.cc

@@ -469,8 +469,8 @@ void PreferencesBrowserTest::UseDefaultTestPrefs(bool includeListPref) {

pref_names_.push_back(prefs::kURLsToRestoreOnStartup);

policy_names_.push_back(policy::key::kRestoreOnStartupURLs);

base::ListValue* list = new base::ListValue;

- list->Append(new base::StringValue("http://www.example.com"));

- list->Append(new base::StringValue("http://example.com"));

+ list->AppendString("http://www.example.com");

+ list->AppendString("http://example.com");

non_default_values_.push_back(list);

}