Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
diff --git a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
index f6e1d88e272362c5031ec2e5902b8135b2d68d69..abbd913c166da88e2fc6d50da1fcf38baeabac1c 100644
--- a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
+++ b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
@@ -49,7 +49,7 @@ base::ListValue* GetHostPermissions(const Extension* ext, bool effective_perm) {
for (URLPatternSet::const_iterator perm = pattern_set.begin();
perm != pattern_set.end();
++perm) {
- permissions->Append(new base::StringValue(perm->GetAsString()));
+ permissions->AppendString(perm->GetAsString());
}
return permissions;
@@ -61,7 +61,7 @@ base::ListValue* GetAPIPermissions(const Extension* ext) {
ext->permissions_data()->active_permissions().GetAPIsAsStrings();
for (std::set<std::string>::const_iterator perm = perm_list.begin();
perm != perm_list.end(); ++perm) {
- permissions->Append(new base::StringValue(perm->c_str()));
+ permissions->AppendString(perm->c_str());
}
return permissions;
}
« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/extensions/api/bluetooth_low_energy/utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698