Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/tracing/chrome_tracing_delegate.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tracing/chrome_tracing_delegate.h" 5 #include "chrome/browser/tracing/chrome_tracing_delegate.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 } 157 }
158 158
159 void ChromeTracingDelegate::GenerateMetadataDict( 159 void ChromeTracingDelegate::GenerateMetadataDict(
160 base::DictionaryValue* metadata_dict) { 160 base::DictionaryValue* metadata_dict) {
161 DCHECK(metadata_dict); 161 DCHECK(metadata_dict);
162 std::vector<std::string> variations; 162 std::vector<std::string> variations;
163 variations::GetFieldTrialActiveGroupIdsAsStrings(&variations); 163 variations::GetFieldTrialActiveGroupIdsAsStrings(&variations);
164 164
165 std::unique_ptr<base::ListValue> variations_list(new base::ListValue()); 165 std::unique_ptr<base::ListValue> variations_list(new base::ListValue());
166 for (const auto& it : variations) 166 for (const auto& it : variations)
167 variations_list->Append(new base::StringValue(it)); 167 variations_list->AppendString(it);
168 168
169 metadata_dict->Set("field-trials", std::move(variations_list)); 169 metadata_dict->Set("field-trials", std::move(variations_list));
170 } 170 }
171 171
172 content::MetadataFilterPredicate 172 content::MetadataFilterPredicate
173 ChromeTracingDelegate::GetMetadataFilterPredicate() { 173 ChromeTracingDelegate::GetMetadataFilterPredicate() {
174 return base::Bind(&IsMetadataWhitelisted); 174 return base::Bind(&IsMetadataWhitelisted);
175 } 175 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698