chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc ('k') | chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc b/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

index 63bf918ac5755e579272525106581036405fd177..6c8a5056e0241d483e1778b3935540cb78ed211f 100644

--- a/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

+++ b/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

@@ -73,9 +73,8 @@ class ManageProfileHandlerTest : public testing::Test {

TEST_F(ManageProfileHandlerTest, HandleSetProfileIconAndName) {

base::ListValue list_args;

- list_args.Append(

- new base::StringValue("chrome://theme/IDR_PROFILE_AVATAR_15"));

- list_args.Append(new base::StringValue("New Profile Name"));

+ list_args.AppendString("chrome://theme/IDR_PROFILE_AVATAR_15");

+ list_args.AppendString("New Profile Name");

handler()->HandleSetProfileIconAndName(&list_args);

PrefService* pref_service = profile()->GetPrefs();

@@ -88,7 +87,7 @@ TEST_F(ManageProfileHandlerTest, HandleSetProfileIconAndName) {

TEST_F(ManageProfileHandlerTest, HandleGetAvailableIcons) {

base::ListValue list_args;

- list_args.Append(new base::StringValue("get-icons-callback-id"));

+ list_args.AppendString("get-icons-callback-id");

handler()->HandleGetAvailableIcons(&list_args);

EXPECT_EQ(1U, web_ui()->call_data().size());