chrome/browser/tracing/chrome_tracing_delegate.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tracing/chrome_tracing_delegate.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tracing/chrome_tracing_delegate.cc

diff --git a/chrome/browser/tracing/chrome_tracing_delegate.cc b/chrome/browser/tracing/chrome_tracing_delegate.cc

index 9ab212e731ec74e9ecf9d930ae855a0dc038bbb5..41f9ab6a3cf542622ac86ad665428186532123f8 100644

--- a/chrome/browser/tracing/chrome_tracing_delegate.cc

+++ b/chrome/browser/tracing/chrome_tracing_delegate.cc

@@ -164,7 +164,7 @@ void ChromeTracingDelegate::GenerateMetadataDict(

std::unique_ptr<base::ListValue> variations_list(new base::ListValue());

for (const auto& it : variations)

- variations_list->Append(new base::StringValue(it));

+ variations_list->AppendString(it);

metadata_dict->Set("field-trials", std::move(variations_list));

}