Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/browser/extensions/convert_user_script.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/convert_user_script.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 85 matching lines @@
   if (!script.version().empty())
     root->SetString(keys::kVersion, script.version());
   else
     root->SetString(keys::kVersion, "1.0");
 
   root->SetString(keys::kDescription, script.description());
   root->SetString(keys::kPublicKey, key);
   root->SetBoolean(keys::kConvertedFromUserScript, true);
 
   base::ListValue* js_files = new base::ListValue();
-  js_files->Append(new base::StringValue("script.js"));
+  js_files->AppendString("script.js");
 
   // If the script provides its own match patterns, we use those. Otherwise, we
   // generate some using the include globs.
   base::ListValue* matches = new base::ListValue();
   if (!script.url_patterns().is_empty()) {
     for (URLPatternSet::const_iterator i = script.url_patterns().begin();
          i != script.url_patterns().end(); ++i) {
-      matches->Append(new base::StringValue(i->GetAsString()));
+      matches->AppendString(i->GetAsString());
     }
   } else {
     // TODO(aa): Derive tighter matches where possible.
-    matches->Append(new base::StringValue("http://*/*"));
-    matches->Append(new base::StringValue("https://*/*"));
+    matches->AppendString("http://*/*");
+    matches->AppendString("https://*/*");
   }
 
   // Read the exclude matches, if any are present.
   base::ListValue* exclude_matches = new base::ListValue();
   if (!script.exclude_url_patterns().is_empty()) {
     for (URLPatternSet::const_iterator i =
          script.exclude_url_patterns().begin();
          i != script.exclude_url_patterns().end(); ++i) {
-      exclude_matches->Append(new base::StringValue(i->GetAsString()));
+      exclude_matches->AppendString(i->GetAsString());
     }
   }
 
   base::ListValue* includes = new base::ListValue();
   for (size_t i = 0; i < script.globs().size(); ++i)
-    includes->Append(new base::StringValue(script.globs().at(i)));
+    includes->AppendString(script.globs().at(i));
 
   base::ListValue* excludes = new base::ListValue();
   for (size_t i = 0; i < script.exclude_globs().size(); ++i)
-    excludes->Append(new base::StringValue(script.exclude_globs().at(i)));
+    excludes->AppendString(script.exclude_globs().at(i));
 
   base::DictionaryValue* content_script = new base::DictionaryValue();
   content_script->Set(keys::kMatches, matches);
   content_script->Set(keys::kExcludeMatches, exclude_matches);
   content_script->Set(keys::kIncludeGlobs, includes);
   content_script->Set(keys::kExcludeGlobs, excludes);
   content_script->Set(keys::kJs, js_files);
 
   if (script.run_location() == UserScript::DOCUMENT_START)
     content_script->SetString(keys::kRunAt, values::kRunAtDocumentStart);
@@ skipping 35 matching lines @@
   if (!extension.get()) {
     NOTREACHED() << "Could not init extension " << *error;
     return NULL;
   }
 
   temp_dir.Take();  // The caller takes ownership of the directory.
   return extension;
 }
 
 }  // namespace extensions