chrome/browser/extensions/policy_handlers.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/policy_handlers.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/policy_handlers.cc

diff --git a/chrome/browser/extensions/policy_handlers.cc b/chrome/browser/extensions/policy_handlers.cc

index 185bdd8aa861af5febfd62cabd25b4dd2d040e3e..44c6eb9d6ab3023398e8ea80617b58fd8e1fd051 100644

--- a/chrome/browser/extensions/policy_handlers.cc

+++ b/chrome/browser/extensions/policy_handlers.cc

@@ -91,7 +91,7 @@ bool ExtensionListPolicyHandler::CheckAndGetList(

IDS_POLICY_VALUE_FORMAT_ERROR);

continue;

}

- filtered_list->Append(new base::StringValue(id));

+ filtered_list->AppendString(id);

}

if (extension_ids)

« no previous file with comments | « chrome/browser/extensions/menu_manager_unittest.cc ('k') | chrome/browser/extensions/policy_handlers_unittest.cc » ('j') | no next file with comments »