chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

index 5a8581b48c1ef9835f32832e4886fa3b6f8c3e4f..f1f6ac6badfa3db3b50671073a145cdd12f84a35 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

@@ -31,6 +31,6 @@ TEST_F(ValidAppManifestTest, AllowUnrecognizedPermissions) {

LoadManifest("valid_app.json", &error));

base::ListValue* permissions = NULL;

ASSERT_TRUE(manifest->GetList("permissions", &permissions));

- permissions->Append(new base::StringValue("not-a-valid-permission"));

+ permissions->AppendString("not-a-valid-permission");

LoadAndExpectSuccess(ManifestData(std::move(manifest), ""));

}