chrome/browser/speech/extension_api/tts_extension_api.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_manager.cc ('k') | chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_api.cc b/chrome/browser/speech/extension_api/tts_extension_api.cc

index e8b3b18c917fed788cd3084d49187af0c255b4c8..7f14336d88710219ee7971b2394ead7675fcacb4 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_api.cc

@@ -337,7 +337,7 @@ bool TtsGetVoicesFunction::RunSync() {

for (std::set<TtsEventType>::iterator iter = voice.events.begin();

iter != voice.events.end(); ++iter) {

const char* event_name_constant = TtsEventTypeToString(*iter);

- event_types->Append(new base::StringValue(event_name_constant));

+ event_types->AppendString(event_name_constant);

}

result_voice->Set(constants::kEventTypesKey, event_types);