Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2065)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index dbd8832c823b5fc1ff33752a791c9113f773f2f8..b9a2a304e80e296599c9055f63098ea16da5668c 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -551,14 +551,10 @@ bool ExtensionActionGetBadgeTextFunction::RunExtensionAction() {
bool ExtensionActionGetBadgeBackgroundColorFunction::RunExtensionAction() {
std::unique_ptr<base::ListValue> list(new base::ListValue());
SkColor color = extension_action_->GetBadgeBackgroundColor(tab_id_);
- list->Append(
- new base::FundamentalValue(static_cast<int>(SkColorGetR(color))));
- list->Append(
- new base::FundamentalValue(static_cast<int>(SkColorGetG(color))));
- list->Append(
- new base::FundamentalValue(static_cast<int>(SkColorGetB(color))));
- list->Append(
- new base::FundamentalValue(static_cast<int>(SkColorGetA(color))));
+ list->AppendInteger(static_cast<int>(SkColorGetR(color)));
+ list->AppendInteger(static_cast<int>(SkColorGetG(color)));
+ list->AppendInteger(static_cast<int>(SkColorGetB(color)));
+ list->AppendInteger(static_cast<int>(SkColorGetA(color)));
SetResult(std::move(list));
return true;
}
« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/idltest/idltest_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698