chrome/browser/extensions/api/storage/settings_sync_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Unified Diff: chrome/browser/extensions/api/storage/settings_sync_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc ('k') | chrome/browser/extensions/api/tabs/tabs_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_sync_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

index 44fdc1490f74fca9a4506efe392fde8855d1a38a..44510b835cf0e6485eb56a936bcacc3c3522c430 100644

--- a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

+++ b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

@@ -304,7 +304,7 @@ TEST_F(ExtensionSettingsSyncTest, InSyncDataDoesNotInvokeSync) {

base::StringValue value1("fooValue");

base::ListValue value2;

- value2.Append(new base::StringValue("barValue"));

+ value2.AppendString("barValue");

ValueStore* storage1 = AddExtensionAndGetStorage("s1", type);

ValueStore* storage2 = AddExtensionAndGetStorage("s2", type);

@@ -353,7 +353,7 @@ TEST_F(ExtensionSettingsSyncTest, LocalDataWithNoSyncDataIsPushedToSync) {

base::StringValue value1("fooValue");

base::ListValue value2;

- value2.Append(new base::StringValue("barValue"));

+ value2.AppendString("barValue");

ValueStore* storage1 = AddExtensionAndGetStorage("s1", type);

ValueStore* storage2 = AddExtensionAndGetStorage("s2", type);

@@ -385,7 +385,7 @@ TEST_F(ExtensionSettingsSyncTest, AnySyncDataOverwritesLocalData) {

base::StringValue value1("fooValue");

base::ListValue value2;

- value2.Append(new base::StringValue("barValue"));

+ value2.AppendString("barValue");

// Maintain dictionaries mirrored to the expected values of the settings in

// each storage area.

@@ -425,7 +425,7 @@ TEST_F(ExtensionSettingsSyncTest, ProcessSyncChanges) {

base::StringValue value1("fooValue");

base::ListValue value2;

- value2.Append(new base::StringValue("barValue"));

+ value2.AppendString("barValue");

// Maintain dictionaries mirrored to the expected values of the settings in

// each storage area.

@@ -498,7 +498,7 @@ TEST_F(ExtensionSettingsSyncTest, PushToSync) {

base::StringValue value1("fooValue");

base::ListValue value2;

- value2.Append(new base::StringValue("barValue"));

+ value2.AppendString("barValue");

// Make storage1/2 initialised from local data, storage3/4 initialised from

// sync.

@@ -625,7 +625,7 @@ TEST_F(ExtensionSettingsSyncTest, PushToSync) {

TEST_F(ExtensionSettingsSyncTest, ExtensionAndAppSettingsSyncSeparately) {

base::StringValue value1("fooValue");

base::ListValue value2;

- value2.Append(new base::StringValue("barValue"));

+ value2.AppendString("barValue");

// storage1 is an extension, storage2 is an app.

ValueStore* storage1 = AddExtensionAndGetStorage(