chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('k') | chrome/browser/extensions/api/storage/settings_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

index 23dc6d7d349ac33e0308937a3030c24ecbc79056..56b8ae0cd9b6efb73f27c8bf47d34f35f55a33a8 100644

--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

@@ -189,8 +189,8 @@ void SettingsOverridesAPI::OnExtensionLoaded(

manifest_keys::kSettingsOverride);

}

std::unique_ptr<base::ListValue> url_list(new base::ListValue);

- url_list->Append(new base::StringValue(SubstituteInstallParam(

- settings->startup_pages[0].spec(), install_parameter)));

+ url_list->AppendString(SubstituteInstallParam(

+ settings->startup_pages[0].spec(), install_parameter));

SetPref(

extension->id(), prefs::kURLsToRestoreOnStartup, url_list.release());

}