Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1244073002: QUIC - disable QuicPacketGeneratorTest.DontCrashOnInvalidStopWaiting (Closed)

Created:
5 years, 5 months ago by ramant (doing other things)
Modified:
5 years ago
Reviewers:
Nico, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Nico, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - disable QuicPacketGeneratorTest.DontCrashOnInvalidStopWaiting BUG=512446 TBR=rch@chromium.org

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -74 lines) Patch
M net/cert/multi_log_ct_verifier_unittest.cc View 1 5 chunks +10 lines, -41 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 1 3 chunks +5 lines, -31 lines 0 comments Download
M net/test/ct_test_util.h View 1 2 chunks +19 lines, -1 line 0 comments Download
M net/test/ct_test_util.cc View 1 2 chunks +33 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244073002/1
5 years, 5 months ago (2015-07-21 17:38:40 UTC) #2
Nico
tests cycled green on http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/1783 after https://codereview.chromium.org/1246793002 got reverted, i don't think disabling this test ...
5 years, 5 months ago (2015-07-21 17:40:35 UTC) #5
ramant (doing other things)
5 years, 5 months ago (2015-07-21 17:43:32 UTC) #6
Message was sent while issue was closed.
On 2015/07/21 17:40:35, Nico wrote:
> tests cycled green on
>
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/...
> after  https://codereview.chromium.org/1246793002 got reverted, i don't think
> disabling this test is necessary

Thanks Nico. Will see why the above unittest is crashing on these platforms and
will fix asap.

Powered by Google App Engine
This is Rietveld 408576698